Thanks for the comments folks, constructive chat is appreciated:

Quoting: GoboSmall bug report here as I didn't want to sign up at GitLab after having a quick peek at your code: when you set $year in calendar_ical.php you seem to have borked the google bot path with the empty content. As of right now calling calendar_ical.php without setting the year parameter will most likely invalidate your SQL later on. I guess in case of an empty $_GET['year'] you might want to set $year = date( "Y" ) just like the first branch.

That is now fixed from levi's pull request.

Quoting: wojtek88I have to say that I see very huge difference between code in gamingonlinux/includes/hashids directory while comparing with other code of the system. Object-oriented approach looks much better from my perspective, and I would follow it in the rest of the code.

That's not my code, as you can tell from the head of the file. It's also not used any more, so can probably be removed.

Quoting: wojtek88What's more - I just took a look on one random file and I found commented code (gamingonlinux/includes/crons/itch_games_import.php). I would strongly recommend that you avoid leaving such a stuff in the code - it makes the code very hard to read and it gives no value. If you want to see old portion of business logic, you should find it in the VCS. Leaving it in code is pointless.

I agree, the small few lines were left in while it was being worked on before, simply forgot to remove. Have now done so.

Quoting: wojtek88And the general note - I see that you tend to use magic numbers and values that have some meaning for you, but it's very hard to find out from the code their meaning while looking at one file...

You raise a good point there, I have set one up in that file so it makes more sense :). For some reason I never think to use constants, so that was a nice reminder.
Edit: To clarify this a bit, I actually do use them, but they are generally configs set in the database. Stuff like that though, should just be in the file itself since it's only used for that one place (which is what I have done now in this case).

Quoting: wojtek88Don't get me wrong Liam, I'm very pleased you've opened the code of the site. I just wanted to share with you my comments, You can do with them whatever you want, I just want to share with you my remarks. Maybe you have your reasons to have different opinion, so we can argue for a moment

It's fine, part of the reasoning for opening it up was so people can point out places that need cleaning that I've likely long forgotten about! It's also quite difficult when it's 99% me alone doing it to not only remember to get things done, but also have time to actually research best practices vs actually fixing issues and putting in needed features to make actually running it easier.

Thanks everyone!

View this comment - View article - View full comments

Quoting: minidougreat, what can we help with?

Pointing out glaring errors and flaws would be a big help right now.

View this comment - View article - View full comments

Quoting: SmilexHow complicated is the game? If I were to introduce this game as a ice breaker for a party, can I expect people to be able to just pick up and play?

VERY simple. All you actually do is move people on the screen, the majority is up to the physics :D

View this comment - View article - View full comments

Quoting: M@yeulCI wish there was some matrix client built into the KDE IM functionality. Well, maybe time for a feature request/patch?

I just use Pidgin with the Matrix plugin, seems to work pretty damn well.

View this comment - View article - View full comments

Quoting: CybolicThey would probably find them easier to fix if they named some of the issues they ran into. I get the limitations of a three man team, but this does seem a bit like giving up before even really trying.

Yeah i asked a few times on Twitter, but they wouldn't give me specifics.

View this comment - View article - View full comments

Quoting: Creak

Quoting: DelaylineGreat offer, this is great game if support Linux natively.

It does... doesn't it?

Yes this game is native. All Feral games are.

View this comment - View article - View full comments

Quoting: AryvandaarSo, you asked for the option to only show Linux games on your homepage in the store?

You can see exactly what I asked in the link, here it is again in case you missed it in the text: https://github.com/itchio/itch.io/issues/564 [External Link]

View this comment - View article - View full comments

Quoting: dmantioneI'm happy that you failed to install Windows. It is really this kind of pragmatism that kills our market share in surveys. Make the Windows-only child games run with Wine, it is acceptable to use it in these kind no other possibility "emergency situations". I would have chosen SteamOS for a TV though.

The thing is though, not all of us are able to make every single decision alone. While I am obviously a Linux user and have been for many years, I don't make every decision for my family by myself. Some things you have to give way on, luckily for me this time around Windows showed how much of a nuisance is that my way won in the end anyway!

View this comment - View article - View full comments

Quoting: Guest

Quoting: liamdaweYes, VR support for Linux is a big reason why Valve is getting Mesa sorted out on AMD.

Yes, indeed. But is VR the only reason? Let's hope they have more up their sleeve.

VR is very demanding hardware and feature wise, so it's easily their main reason.

View this comment - View article - View full comments

Quoting: GuestI get the impression Valve is going to announce/release something in the not-too-distant-future. They've been clearing a path of any and all obstacles, and for Linux gamers, the last real ones were that proper support for AMD cards had fallen way behind. I don't think it'll be like that much longer.

Yes, VR support for Linux is a big reason why Valve is getting Mesa sorted out on AMD.

View this comment - View article - View full comments