Massive apologies about this, seems it was linked to another issue someone reported to me.

When updating the code a week ago, I was trying to be smart (doh!) and ended bundling together the code that updates notifications, regardless of if you've read them or not it would update the existing row.

I've since split this back as it should, to simply add to the total if you haven't seen it and overwrite it if you have seen it with the new details.

Thanks! It appears to be back to normal.

Thanks for fixing it this fast!
You're really dedicated to your website!

Good news, one less thing to deal with ;)

Not sure if related to the same bug, but for at least 2 days now my notification links keep sending me to the very bottom of the page instead of scrolling to the comment in question.
Example link: https://www.gamingonlinux.com/articles/valve-has-removed-the-steam-machine-section-from-steam.11505/page=6#r120557

Looking at the page source there's only one element with that id and it seems to be where it should, so I'm not sure what is going on. Using Firefox 59.0.2, no active addons that should be getting in the way.

That's unrelated and will be browser dependent. It's simply using HTML anchor links, so if it's not working there's literally nothing I can do to help really.

I mostly fails for me too on firefox, but clicking the address bar and hitting enter jumps to the right comment.

Liam: You could set the scroll position with javascript after everything is loaded. That should work but probably overkill.

EDIT: Also maybe highlight the linked comment?

Also using FF59, but I have no problems with it. Both on Linux at home and Windows at work.

[edit]

Ok, I need to change that. This one fails consistently:

https://www.gamingonlinux.com/articles/rise-of-the-tomb-raider-is-now-officially-available-on-linux-heres-a-look-at-it-with-benchmarks.11576/page=20#r120609

If can copy/paste this link into a new tab. It will load the page, then a short flash where it will actually be at the correct post after which it will move to the bottom of the page.

FYI, to link directly to comments properly, you need to copy the link. As it's different for everyone based on how many they set to display per-page.

So: https://www.gamingonlinux.com/articles/rise-of-the-tomb-raider-is-now-officially-available-on-linux-heres-a-look-at-it-with-benchmarks.11576/comment_id=120609

I can now confirm the issue, but only in Firefox, works 100% of the time in Chrome. Will investigate.

Could it be related to the "Click to view long quote from..." feature? I assume the page loads all content then it gets shrunk with JS, and that throws Firefox off somehow?

Though Ehvis's link above works as expected for me every time and there's long quotes in it too.

Quoting: SalvatosCould it be related to the "Click to view long quote from..." feature? I assume the page loads all content then it gets shrunk with JS, and that throws Firefox off somehow?

Though Ehvis's link above works as expected for me every time and there's long quotes in it too.

Ohhhh, didn't think of that. You may very well be right about that! Interesting, will have to think on how to best solve that one.

Quoting: liamdawe

Quoting: SalvatosCould it be related to the "Click to view long quote from..." feature? I assume the page loads all content then it gets shrunk with JS, and that throws Firefox off somehow?

Though Ehvis's link above works as expected for me every time and there's long quotes in it too.

Ohhhh, didn't think of that. You may very well be right about that! Interesting, will have to think on how to best solve that one.

I think my suggestion to set the scroll position after everything else is done should work. That's not too hard with jQuery or the experimental [Element.scrollIntoView()](https://caniuse.com/#feat=scrollintoview) method.

Okay, this should now be solved, works with 100% replication in both Chrome and Firefox for me now.

I'm now counting the quotes, once the JS loop has finished, it will then use the scrollIntoView() method :)

Appears to work beautifully now!

Seems fixed for me too! Good job and thanks!

It appears something got broken again. Clicking the comment links in the side bar now scrolls two far (title and approx. two lines are clipped).

It's fine when you click links from the "see more comments" page though. Apparently the ?page=...#id version broke, but the /comment_id=... version is still ok.

Actually, nothing broke, I just never updated the sidebar :P

Done, fixed.

Thanks!

Something must have changed though. It worked when you fixed that last problem. Anyway, good to have the permanent solution in there!