Join us on our own very special Reddit: /r/Linuxers
New quote feature
Ehvis 20 Jul

The new feature to quote selected text is quite nice in itself. I see two issue though.

1. Quoting from within quoted text attributes the quote to the writer of the post and not to the original author. A minor thing, but it might lead to confusion down the road as even in the old system people seem to have messed up their quotes regularly. Might even be best to leave copy the entire "quote tree" if at all possible.

2. A much bigger issue (for me anyway), is that text is deselected when you right click it. Which means no "copy" or "search" options. This loss is bigger for me than the gain of the quote option.

Liam Dawe 20 Jul

Quoting: Ehvis1. Quoting from within quoted text attributes the quote to the writer of the post and not to the original author. A minor thing, but it might lead to confusion down the road as even in the old system people seem to have messed up their quotes regularly. Might even be best to leave copy the entire "quote tree" if at all possible.
Yes, I have been thinking on the best way to handle that. My options are basically some annoying DOM traversal in JS to find the quoted person or to not allow the feature in quotes which is likely the best option.

Quoting: Ehvis2. A much bigger issue (for me anyway), is that text is deselected when you right click it. Which means no "copy" or "search" options. This loss is bigger for me than the gain of the quote option.
Sorry about that, should be solved now tested across Firefox, Chrome, Brave and Opera.

Edit: also just solved the button going underneath the next comment box if you were selecting the bottom row of text.

Last edited by Liam Dawe on 20 July 2020 at 10:15 am UTC

Ehvis 20 Jul

Quoting: Liam DaweSorry about that, should be solved now tested across Firefox, Chrome, Brave and Opera.

Woohoo! Thanks, works great now!

Liam Dawe 20 Jul

Happy to hear that :)

I'll start looking into the best way to target existing quotes to ignore them this week, just need to work out the correct flow with the current implementation.

CatKiller 20 Jul

The "long quote" text is wrong now. It says Click to view long quote from Quoting: $user instead of Click to view long quote from $user.

Also, the "like" button seems to be MIA.

Liam Dawe 21 Jul

Quoting: CatKillerThe "long quote" text is wrong now.
Fixed.

Quoting: CatKillerAlso, the "like" button seems to be MIA.
Unrelated, that will be a privacy plugin being overzealous blocking it thinking it's social network stuff. We've made small attempts to re-word some CSS classes to get around it but really it's not our bug.

CatKiller 21 Jul

Quoting: Liam Dawe
Quoting: CatKillerThe "long quote" text is wrong now.
Fixed.
Yay!
Quoting: Liam Dawe
Quoting: CatKillerAlso, the "like" button seems to be MIA.
Unrelated, that will be a privacy plugin being overzealous blocking it thinking it's social network stuff. We've made small attempts to re-word some CSS classes to get around it but really it's not our bug.
Certainly possible: I do use Privacy Badger. It was working till a couple of days ago, though, and it's working again from whatever you changed, so thanks.

Last edited by CatKiller on 21 July 2020 at 11:08 am UTC

Liam Dawe 24 Jul

Have today made more improvements to it. It will no longer let you selectively quote a quote inside a post, because that adds to the confusion and leads to all the massive quotes we have already. It's supposed to be a feature to let you selectively quote *that* person, so now it's as expected.

It will also no longer let you selectively quote the likes bar since it's not supposed to. I think we're nearly finished with it. There's some positioning issues with the Quote button that appears in some browsers but it's minor. After that's sorted, we can look to make it prettier....

Ehvis 24 Jul

The quote selection works like a charm. Very nice! However, it does not put the quote tags in for the nested quotes, so it's not (yet) a replacement for quoting the full post and then deleting what you don't need.

Liam Dawe 24 Jul

Quoting: EhvisThe quote selection works like a charm. Very nice! However, it does not put the quote tags in for the nested quotes, so it's not (yet) a replacement for quoting the full post and then deleting what you don't need.
That's what I just posted about above, it's not targeting existing quotes.

While you're here, please consider supporting GamingOnLinux on:

Patreon, Liberapay or PayPal Donation.

We have no adverts, no paywalls, no timed exclusive articles. Just good, fresh content. Without your continued support, we simply could not continue!

You can find even more ways to support us on this dedicated page any time. If you already are, thank you!

You need to Register and Login to comment, submit articles and more.


Or login with...