Patreon Logo Support us on Patreon to keep GamingOnLinux alive. This ensures all of our main content remains free for everyone. Just good, fresh content! Alternatively, you can donate through PayPal Logo PayPal. You can also buy games using our partner links for GOG and Humble Store.
Title: [IN TESTING - LIVE] Option to change number of posts/comments per page
Page: 1/2
  Go to:
redshift 31 May 2016
I couldn't find the option to do so. Not sure if it's hard to implement, but I'd find it rather convenient to have more than 10 posts per page since heated discussions have a lot of pages. This includes forums and news articles.
Liam Dawe 1 Jun 2016
Should be pretty simple to implement (already on my list), but it may be a feature only rolled out to Patreon supporters.

The main reason is of course to give small, but useful extra to people who directly support me/GOL.
Xpander 1 Jun 2016
ohh i would like that feature.
make it 50 or even 100 per page as a option also
redshift 2 Jun 2016
Quoting: liamdaweThe main reason is of course to give small, but useful extra to people who directly support me/GOL.
Not a problem, I think. Would be good if you eventually have a list of what patrons will get. Although, to be frank, I would have liked if experience was identical for everyone and people would support you because of a great site and not because they want a specific gated feature.

Just my thoughts, it's your call obviously. I'm not a supporter(and a new one!) so my opinion not matter much in such discussions.
Liam Dawe 3 Jun 2016
I'm leaning towards agreeing that such a basic feature should be rolled out to everyone. I probably will allow everyone to use it, as it's such a simple but useful thing I don't feel quite right having it behind a "pay wall" so to speak.
Liam Dawe 3 Jun 2016
Okay, this is now up. There is a new bit in the User CP to control it. Please do let me know if anything is broken as a result of it.
Liam Dawe 3 Jun 2016
Update: Added in an ability to edit how many articles are shown per-page, also in the User Control Panel.

Let me know of any breakage with that too will ya.
tuubi 3 Jun 2016
User Avatar
Seems like the links on the Latests Comments page and that widget on the right do not respect the setting. After increasing comments per page I get links to page 5 of 2 etc. It might be better if these links just referenced the comment itself and the receiving end took care of showing the right page? (So the link would be something like http://gamingonlinux.com/articles/title.1234/#comment_12345) This way it would be trivial to highlight the post in question as well. Sorry, I guess can't help myself... :dizzy:
Liam Dawe 3 Jun 2016
Fixed the latest comments page and widget for this.

I have also adjusted them as requested to link directly to the comment, I should have done that to begin with so it was valid you bringing it up. Thanks.
redshift 3 Jun 2016
That's awesome! Thanks.
Really glad I don't need to click next page while reading popular news posts.
Xpander 4 Jun 2016
thanks for that feature. really liking it
tuubi 4 Jun 2016
User Avatar
Quoting: liamdaweI have also adjusted them as requested to link directly to the comment, I should have done that to begin with so it was valid you bringing it up. Thanks.
Great job, man, and a very convenient feature.
Liam Dawe 4 Jun 2016
*insert rum here as thanks* ;)
tuubi 4 Jun 2016
User Avatar
External Media: You need to be logged in to view this.

The rum goes in my tum, yum.
tuubi 4 Jun 2016
User Avatar
Oh, before you pop that cork, the Latest Forum Posts widget needs fixing as well.
redshift 4 Jun 2016
I think having these kind of options acts as a good incentive to register even if you don't want to comment. That, and new survey. Customising in how I read and view site is a big plus for me. Not sure how others feel, but having this options surely enhances my experience.
Liam Dawe 4 Jun 2016
Quoting: tuubiOh, before you pop that cork, the Latest Forum Posts widget needs fixing as well.
Should also now be fixed :)

Quoting: redshiftI think having these kind of options acts as a good incentive to register even if you don't want to comment. That, and new survey. Customising in how I read and view site is a big plus for me. Not sure how others feel, but having this options surely enhances my experience.
Glad I could help make it better :)

Any other issues, let me know.

I know that comment/post linking won't work correctly now, since everyone may see it on a different page. Currently brainstorming a solution, but it's not a major issue right now to spend too much time trying to fix just yet.
tuubi 5 Jun 2016
User Avatar
Quoting: liamdaweI know that comment/post linking won't work correctly now, since everyone may see it on a different page. Currently brainstorming a solution, but it's not a major issue right now to spend too much time trying to fix just yet.
I agree it's not a big problem and there's no hurry, but I at least tried to hint at a possible solution to this as well in my first comment. Drop the page number reference in the link urls and let the script that shows the article or forum post take care of showing the correct page of comments. This would also reduce the number of places that deal with paging and might make things simpler / more robust. Of course I've never seen your code and this might not be simple at all.
tuubi 5 Jun 2016
User Avatar
Just noticed that comment links in emails sent by the system can't deal with this stuff yet. One sent me to page 4/2 just now.
Liam Dawe 5 Jun 2016
Quoting: tuubiJust noticed that comment links in emails sent by the system can't deal with this stuff yet. One sent me to page 4/2 just now.
For what exactly, forum post, article comment?
Fixed that, thanks.

Quoting: tuubi
Quoting: liamdaweI know that comment/post linking won't work correctly now, since everyone may see it on a different page. Currently brainstorming a solution, but it's not a major issue right now to spend too much time trying to fix just yet.
I agree it's not a big problem and there's no hurry, but I at least tried to hint at a possible solution to this as well in my first comment. Drop the page number reference in the link urls and let the script that shows the article or forum post take care of showing the correct page of comments. This would also reduce the number of places that deal with paging and might make things simpler / more robust. Of course I've never seen your code and this might not be simple at all.
It won't make anything simpler, as the current code would simply grab the page from the url (the simplest way). I will now need to do a bunch of math and check the post amounts in the database to work out a correct page.

Actually it will make two places a tiny bit simpler, since I won't work out pages for the email links. The rest is annoying though, actually working out the correct page when you hit the link with the comment_id. Will still need a wee think on it.
tuubi 5 Jun 2016
User Avatar
Quoting: liamdawe
Quoting: tuubiJust noticed that comment links in emails sent by the system can't deal with this stuff yet. One sent me to page 4/2 just now.
For what exactly, forum post, article comment?
Fixed that, thanks.
Don't thank me, you're the one that's working on a sunday. :P

Quoting: liamdaweIt won't make anything simpler, as the current code would simply grab the page from the url (the simplest way). I will now need to do a bunch of math and check the post amounts in the database to work out a correct page.

Actually it will make two places a tiny bit simpler, since I won't work out pages for the email links. The rest is annoying though, actually working out the correct page when you hit the link with the comment_id. Will still need a wee think on it.
Yeah, I didn't mean simpler in that sense. Just that it's often better to do the work in as few places as possible, even if it takes a bit more logic, thus reducing duplication of code and making the codebase simpler to manage.

Is it hard for the script to find out the position of the comment in the thread, and then just do a modulus with the user's comments-per-page setting to find out the page? (Hope that makes sense, I think my brain's on strike today.)
While you're here, please consider supporting GamingOnLinux on:

Reward Tiers: Patreon Logo Patreon. Plain Donations: PayPal Logo PayPal.

This ensures all of our main content remains totally free for everyone! Patreon supporters can also remove all adverts and sponsors! Supporting us helps bring good, fresh content. Without your continued support, we simply could not continue!

You can find even more ways to support us on this dedicated page any time. If you already are, thank you!
Login / Register