Looks like patches for Invisible Monsters and Caves(?) exist now :)

Wish I wouldn't be that lazy nowadays to compile myself.

Quoting: bekoLooks like patches for Invisible Monsters and Caves(?) exist now :)

Yes, caves patch is in review already, and invisible monsters one is still a hack so will be manual for now. I'll test it later today. Building Wine can be easy, but gets more tedious with customization. I spent some time writing automation scripts for the whole thing (including partial staging and manual patching). If you are lazy, write scripts to do the repetitive work ;)

Quoting: ShmerlIf you are lazy, write scripts to do the repetitive work ;)

Yeah, that's what I did. I've manually cloned the wine and wine-staging repositories once, and then have the following script next to both directories:
#!/bin/sh
cd wine
git checkout .
git clean -f
git pull
cd ../wine-staging
git pull
cd patches
./patchinstall.sh DESTDIR=../../wine wined3d-buffer_create wined3d-Copy_Resource_Typeless d3d11-Deferred_Context wined3d-GenerateMips
cd ../../wine
CFLAGS="-march=native -O3" CXXFLAGS="-march=native -O3" CC=gcc-7 CXX=g++-7 ./configure --enable-win64 --disable-tests --prefix=/opt/wine-witcher
make -j 4
sudo make install
From time to time it needs a bit of tweaking, like checking out a specific wine revision to get the staging patches to apply correctly, or to add a manual patch like now with the invisible ground fix. But once you have even those few lines in place, doing a new build is really painless.

Heh, mine is a bit more complex, since I'm building inside a VM. I might put it up somewhere to Github gist later (after some cleanup).

https://gist.github.com/shmerl/bbd448bc2b579831a82df7bae3de8dc5

You can override branch there as needed (with env variable).

I.e. for example:

wine_branch=wine-2.21 ./tw3_wine_build.sh

Since current staging fell behind.

If you want to patch staging patches themselves to make limited set of TW3 patches applicable to Wine master, here is a temporary diff:

https://pastebin.com/raw/X3qmauUF

Marek Olšák pushed [this fix](https://cgit.freedesktop.org/mesa/mesa/commit/?id=b5444877c0820b7848c07d1bc4e9a706f90894a5), and Mesa is back to normal to good performance and no flickering!

Though now there is a problem with invisible monsters fix. It causes a freeze again :(

Finally, mountain path scene renders correctly without missing surfaces! Same "caves" fix helped.



With distorted monsters fix, now this new freeze is the only major issue left it seems.

Quoting: Shmerlhttps://gist.github.com/shmerl/bbd448bc2b579831a82df7bae3de8dc5

Wow, that's production-grade code :-). Simple and beautiful!

Quoting: ShmerlThough now there is a problem with invisible monsters fix. It causes a freeze again :(

I can confirm this. Monsters are visible now, but the whole system froze after a while... :/

Quoting: ShmerlFinally, mountain path scene renders correctly without missing surfaces! Same "caves" fix helped.

External Media: You need to be logged in to view this.

With distorted monsters fix, now this new freeze is the only major issue left it seems.

All those fixes and still at a good 41 fps I see :-)

Looks like a fully working Witcher 3 on Linux is not too far away.

Quoting: lodI can confirm this. Monsters are visible now, but the whole system froze after a while... :/

Can you comment in the bug please and specify your hardware / driver?

Quoting: kaimanWow, that's production-grade code :-). Simple and beautiful!

Thanks! Splitting into functions helps making ad-hoc variants of the script with some steps commented out. It comes handy once in a while.

Hi Shmerl, thx for the Mesa 17.4 testing and the bugreport. I tested yesterday a little with 4.15-rc1 and Mesa 17.4 with a patched Wine 2.21 (3 staging patches and patch for invisible Textures). I had a lot of fun. I played with 2560x1080 with middle to high settings. I made the main quest with the witches in the swamp. I noticed that my fps drops a lot if there are light sources e.g. in the cut scene with the witches I got 50-60 fps if there are no candles visible. The fps dropped immediately to around 30 if there came candles into the picture.

What are your settings for the screenshot at Kaer Morhen? I wanna test and compare the performance.

Quoting: maspeberWhat are your settings for the screenshot at Kaer Morhen? I wanna test and compare the performance.

CPU: Ryzen 7 1700X
GPU: Sapphire Nitro+ RX 480
Res: 1920x1200
OpenGL renderer string: AMD Radeon (TM) RX 480 Graphics (POLARIS10 / DRM 3.18.0 / 4.13.0-1-amd64, LLVM 5.0.0)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.4.0-devel (git-d7c8c7bd9d)
Wine master with 3 rebased staging patchsets and manual patches for missing surfaces and invisible monsters.

Max settings, hairworks off, ambient occlusion: HBAO+. That's a screenshot from the very beginning of the game.

Thx for the quick answer. Very funny that your RX 480 is loaded to nearly 100%. My best load yesterday was max 80%. Most time it stay around 70%. I will post later a screenshot with the same settings like yours.

How soon does the crash occur and does it occur everywhere? Or does it only happen when there is a situation that is handled by the invisible models hackpatch?

Quoting: FaattoriHow soon does the crash occur and does it occur everywhere? Or does it only happen when there is a situation that is handled by the invisible models hackpatch?

It happens only around those previously affected monsters, and not right a way, but some seconds after you approach them.

Ok, looks like it's something Mesa only like the last freeze. On Nvidia drivers everything seems to work fine.

Tried to look around for the previously invisible models and everything seemed to work. Not sure if placebo or even gained some FPS too.

This is my Vega56 shot:



Resolution: 1920x1200 (with virtual desktop in winecfg), lower part not displayed because I only have 1980px). All Ultra, HBAO+, no Hairworks.

inxi -F
CPU: Octa core AMD Ryzen 7 1700 Eight-Core (-HT-MCP-) cache: 4096 KB
clock speeds: max: 3800 MHz 1: 3044 MHz 2: 3037 MHz 3: 3043 MHz 4: 3135 MHz 5: 3037 MHz 6: 3056 MHz
7: 3045 MHz 8: 3066 MHz 9: 3604 MHz 10: 3776 MHz 11: 3037 MHz 12: 3046 MHz 13: 3037 MHz 14: 3050 MHz
15: 3038 MHz 16: 3058 MHz
Graphics: Card: Advanced Micro Devices [AMD/ATI] Vega [Radeon RX Vega]
Display Server: x11 (X.Org 1.19.5 ) drivers: ati,amdgpu (unloaded: modesetting,fbdev,vesa,radeon)
Resolution: [email protected]
OpenGL: renderer: AMD VEGA10 (DRM 3.23.0 / 4.15.0-041500rc1-generic, LLVM 5.0.1)
version: 4.5 Mesa 17.4.0-devel

Funny same fps as you Shmerl but my card is only 70% loaded but at full clock with full energy target - 150W (powersafe bios).